Design comparison
Solution retrospective
Hi, this my solution for this time. I know it's not 100% same, but comments are welcome to make it better. I use Atom to build this site. For some reason, I don't know why background image not appear, I think I wrote the right code. I intend to learn more and more to make it better and always learning, thank you...
Community feedback
- @T-NabeelPosted over 2 years ago
When uploading files to github, create a repository and push the work files to that repository.
For your question, to display the background image, change the code like this. π It should work.
#logo-header { background-image: url("../images/bg-header-desktop.png"); }
0 - @Sdann26Posted over 2 years ago
Hi Khairul!
The reason why you can't see it is because your project is also in a folder, the po repository does work as one, so your link is the following:
https://kfadhz.github.io/Clipboard-Landing-Page-Challenge/Clipboard%20Landing%20Page/
I was looking at your project and personally to the download buttons for windows and Mac I would give more padding in general.
I would also add effect to the links that appear in the footer as they are usually links to navigation as well as to the social networks so that they work as links that take you outside.
Also I recommend that you see the report that has generated many errors in if most is because you have not used the <main> tag you have used by <section>. I would recommend you to put all the <section> inside a <main> except the last one that you could change it to a <footer> tag. Try to use more semantic tags as that improves your page ranking when uploaded.
For now that's what I can recommend you try to make those changes especially the tags until your report is error free, it will make you a better front-end developer. Good luck!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord