Clipboard landing page challenge hub

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  Hello, Mali! 👋

  Good effort on this challenge! 👍 It looks different with the design, are you trying to redesign the website?

  Anyway, there are some areas that you can improve.

  • In this case, the button elements don't have to be wrapped by div elements. Try to make the button as display: inline-block and remove the div. Also, the download buttons should link elements with download attribute for every link.
  • Next time, if you are going to use button element (e.g. submit button), always specify the type of the button element. If it is a submit button then type="submit" and if it is going to toggle a modal, you want it to be type="button". This prevent the button behave unexpectedly.
  • Each social media icon should be wrapped with link element. You can use aria-label="Facebook" to work as the label for the link element or use sr-only text so that the screen reader users know that there is a social media link.

  That's it! Happy coding! 😁

  Marked as helpful

  2

  ---

  

  Mali Gaurav•30

  @maligaurav947Posted over 2 years ago

  @vanzasetia Really Help The Points You Clear Thank You For Feedback i will take more care next time

  0

  

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  @maligaurav947 You're welcome! 👍

  0

  

  2div•170

  @2divPosted over 2 years ago

  @vanzasetia Hi , your tips about the button and social media links are very helpful , can you share learning material such as website for more details about the buttons and link so that i learn more. TIA

  0

  

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  @2div You can follow this rule, anchor tags are for navigation - moving to different pages or content on the same screen, while the button elements are for actions like opening a modal, submitting a form, toggling element, etc.

  A11y Project has a great blog post on how to make an accessible link. Hopefully, this helps.

  P.S. English is not my native language so, is that true that "TIA" stands for Thanks In Advance?

  1

  

  2div•170

  @2divPosted over 2 years ago

  @vanzasetia Thank you for your reply.

  Yes TIA is short for Thank you in advance.

  1

  

  2div•170

  @2divPosted over 2 years ago

  @vanzasetia

  In above challenge what is the right thing to use , anchor tag or button ?

  Thanks

  0

  

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  @2div You're welcome! The download buttons should be anchor tags with download attribute. 😉

  1