Design comparison
Solution retrospective
Hello There, I'll be so happy to read your feedback. You are very welcome.
Community feedback
- @brasspetalsPosted almost 4 years ago
Hi, Salah! 👋
Congrats on completing your first "full-page" challenge! Overall it's pretty good, but I have a few suggestions:
-
From the design preview, you can see the desktop font size needs to be increased for most font elements.
-
Logos overflow the layout for about 20px starting at 950px. They are cramped and reach all the way to the edge of the window until about 1200px. I'd go back in to see if you could add some paddings or margins to fix this.
-
Sections should also always have an
h#
, so I would turn logos container into a div that is part of the “super-charge” section. Doing this should also get rid of the error in your report -
The clipboard paragraph text expands quite far on desktop - a max-width might be good here.
-
The social media links do not need to be inside
span
tags.
Happy coding!
1 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord