Design comparison
Solution retrospective
This was a great challenge. It's my first landing page. I need to practice flexbox a lot, so I'm on to the next challenge.
I'd love your feedback about this work. Cheers people!
Have a great day of coding..
Community feedback
- @jakegodsallPosted 8 months ago
Hi 👋
Great job with this landing page. It looks really great!
I especially like how you've made the hero section of the page take the full viewport height. Looks very professional.
If there was one area of improvement I would recommend to add a constraint to the width of the content of the page, as with very wide viewports the content becomes very spread out. This also leads to a problem with your second
<section>
component slowly trailing towards the left as the viewport gets wider.A common solution to this problem would be to wrap the entire content in a
<div>
and apply CSS to that<div>
giving it a percentage basedwidth
property, and a fixed-valuemax-width
.You would then need to set the
overflow: hidden
of that<div>
for that image in the second section to make sure it doesn't overflow the boundary.Overall though fantastic work. I really like it.
Marked as helpful0@jakegodsallPosted 8 months ago@Jeancyjr You're very welcome! Keep up the good work 👍
0 - @PiriyaLapaPosted 8 months ago
Hi, I tried to review your finished project, everything perfect but I found a little issue with responsive design as part of the section had over space,(You can find the issues picture in your discount post).
0@JeancyjrPosted 8 months ago@PiriyaLapa Yes, I tried to style some text to look exactly like the original design but I couldn't find a way to do that. So when displayed on smaller screen some paragraph texts don't look good. I'll work on that.
Also, some over space is just the normal setting of the original design. So I tried to keep it as close as the original.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord