Design comparison
Solution retrospective
I think this would be better if I added animation on scroll but unfortunately I don't know how to do that
Community feedback
- @benjoquilarioPosted about 3 years ago
Hey @reydelshit.
Great job on finishing this one. It looks good and response rather well and I really like the hover effects on your <button> tag.
Some suggestion:
-
The website logo should have alt="
clipboard homepage
as a value or any name you want. Avoid using words that relates to "graphic" like "logo, image, icon.." as the value for alt attribute. -
The HTML file must contains this.
<header></header>
<main></main>
<footer> </footer>
all element that has content are inside their respective landmark elements.-
Instead of using
<img>
elements to wrapping your.company__logos
you should use anchor element <a> because this element is going to transfer user somewhere. Ex:<a href="#"> the image of the company logo here </a>
-
The footer link also should have anchor element <a>. Because this element is also going to transfer user somewhere.
<li><a href="#">FAQs</a></li>
Keep coding and Good Luck
Marked as helpful0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord