@vanzasetia
Posted
Hello, Urinzi! 👋
Congratulations on finishing this challenge! 🎉
A couple of things I'd like to suggest are,
- Use the correct font family for the site. Currently, it is different from the original design.
- The alternative text for the
images/logo.svg
should be the company name (just like you did with the images inside thebrands
div) - The social media icons should be wrapped by link elements. They have interactivity so they should be wrapped by interactive elements.
- Also, the social media icons are not showing up on my view (
1280px
*670px
). Try to fix this issue. - Use
rem
or sometimesem
unit instead ofpx
. Usingpx
will not allow the users to control the size of the page based on their needs. I recommend reading this tutorial article aboutrem
andem
unit. This article explains both units in a simple way. I recommend reading it if you're not confident to use those units.
Hope this helps! 🙂
Marked as helpful
@jc-padua
Posted
@vanzasetia thank you for pointing out my mistakes, I always forget to put some alternative text as I feel excited when the site starts looking good hehe. I'll try to fix and change the site based on your suggestions. Thank you so much!
@vanzasetia
Posted
@jc-padua No problem! 👍