Clipboard Landing Page

Community feedback

• 

  mycrochip•460

  @mycrochipPosted over 2 years ago

  Hi Veronica,

  Well done on completing this challenge. It looks great and it could be better.

  You could set a max-width on the blocks holding your texts (in the computer section)

  Also, you left me out of your sponsors' list, don't I contribute enough quota 😎 (says Microsoft)

  All the same, you are doing good and with more practice will get the font size/screen ratio

  Happy coding!

  Marked as helpful

  0

  ---

  

  Veronica Valdez•130

  @veronicajujuyPosted over 2 years ago

  @mycrochip Thank you. CSS is very hard to me. In this challenges, i would prove lots of properties and selectors. Sorry i don't underestand about my sponsor's lists 😅

  1

  

  mycrochip•460

  @mycrochipPosted over 2 years ago

  @veronicajujuy You're welcome, Veronica.

  About the sponsors' list, I was referring to a section on your website. The Microsoft logo was not included.

  0
• 

  Ahmed Bayoumi•6,740

  @Bayoumi-devPosted over 2 years ago

  Hey Veronica, You have some accessibility issues that need to fix.

  • Heading levels should only increase by one,... Ordered headings make it easier to navigate and understand when using assistive technologies.

  • Using more than one <h1> is allowed by the HTML specification, but is not considered a best practice. Using only one <h1> is beneficial for screenreader users.

  ---> Multiple <h1> elements on one page

  • Links must have the discernible text, when using <svg> inside the anchor link <a> without text, need to set the attribute aria-label to describe the link... Example:

  <a href="#" aria-label="Facebook Page">
        <svg class="logo-contacto-ref" width="24" height="24" xmlns="http://www.w3.org/2000/svg">
            //....
       </svg>
  </a>
  

  Hope this is helpful to you... Keep coding👍

  Marked as helpful

  0

  ---

  

  Veronica Valdez•130

  @veronicajujuyPosted over 2 years ago

  @Bayoumi-dev Thank you Ahmed! i going to do that!!

  0