Clipboard Landing FrontendMentor Solution by Guido Aranda

Community feedback

• 

  Benjo Quilario•1,810

  @benjoquilarioPosted over 2 years ago

  Hi GuidiUZ, great job on finishing this one, it looks good and response rather well.

  some suggestion to improve your code;

  • You need to change your <input /> button into <button> tag. The difference is that <button> can have content, whereas <input> cannot (it is a null element).
  • Instead of using <img> elements to wrapping your .logo, .logo-empress, .socials and .footer-nav you should use anchor element <a> because this element is going to transfer user somwhere.
  • Considering adding a alt attribute on your images. Read more why we need to add alt

  Good luck with that, have fun coding!

  cheers, benjo

  Marked as helpful

  1

  ---

  

  Guido Aranda•120

  @GuidiUZPosted over 2 years ago

  @benjoquilario Thank for your time. I will implement what you have recommended. <3

  0
• 

  Gerri Ezeocha•460

  @GerriEzeochaPosted over 2 years ago

  Well done Guido! My suggestion is to check your 'snippet'( your class name seems to thirdtext) section again. your text content is off. I don't think you need those span elements in there. Also it is recommended to use the 'div' element to generally group content for styling specifically while 'section' markup simply helps with the 'outline of a page.

  keep up the good work.

  Marked as helpful

  0

  ---

  

  Guido Aranda•120

  @GuidiUZPosted over 2 years ago

  @GerriEzeocha Hello, thank you very much for your time. I have used the span to adjust the line breaks in different resolutions, I don't know if it is the correct way but it worked for me. I will implement what you recommend anyway. <3

  0