Clear HTM and CSS

Community feedback

• 

  MaRou•80

  @MaRou-CodePosted over 3 years ago

  Hello there, I'm a newbie and I've never taken this challenge but here are some advice that I think might hopefully help you.

  • First of all, get rid of the text with no tag at the beginning of your body tag.
  • Avoid inline styling at all cost. It's not maintainable, especially on larger scale projects.
  • Concerning the image overlay, there is a very usefull and effective technique : background: url(#) repeat color; You should obviously replace the hashtag with your image url and the color with the color of your choice.
  • I think a grid approach could be pretty effective for this kind of layout. Here you will find a complete guide to grid. Your layout will be more responsive with this approach.
  • For even more responsiveness, try to use media queries to adapt your layout to all screens.
  • By default, the browsers display your content from left to right, so I think it's a best practice to do the same when organising our tags. I would definitely put the image after the other div's, just because it seems more easy to read and to understand for someone else and even for you in a few month. (My apologies if you speak a language which is read from right to left, this approach would seem probably less "logical").

  I hope these comments will be helpfull to you. Keep having fun programming !

  2

  ---

  

  SmoothCrimminal•135

  @SmoothCrimminalPosted over 3 years ago

  @MaRou-Code Woow Thank you soo much for this comment, your advices for sure will be very usefull for me and would let me improve faster. I would try to make changes in my code ASAP, I hope you will have a lot fun while programming too :)

  0