Clean CSS and Vanila JavaScript

Community feedback

• 

  Adriano•38,120

  @AdrianoEscarabotePosted about 2 years ago

  Hi Flaviu Dragomir, how are you?

  I really liked the result of your project, but I have some tips that I think you will enjoy:

  • To improve the accessibility of the project you could have put an h1. Every page must contain a level 1 header, for people who use screen readers, identity what the main title is.
  • Consider using rem for font size .If your web content font sizes are set in absolute units, such as pixels, the user will not be able to re-size the text or control the font size based on their needs. Relative units “stretch” according to the screen size and/or user’s preferred font size, and work on a large range of devices.

  The rest is great!

  I hope it helps... 👍

  Marked as helpful

  0

  ---

  

  Flaviu Dragomir•150

  @FlaviuD94Posted about 2 years ago

  Hi @AdrianoEscarabote , great, hope you are doing great too.

  Thank you for your advice, much appreciated! I didn't use an h1 in this one , because I think about it as a reusable component. Regarding the relative units I completly agree with you. I don't feel confortable with it untill now because in some cases I think that it will break my style, but it's a must that I have to master as soon sa I can.

  Wish you all the best!

  1

  

  Adriano•38,120

  @AdrianoEscarabotePosted about 2 years ago

  @FlaviuD94 I'm not used to using rem either, but recently a friend of mine introduced me to a very useful extension!

  It converts px to rem! recommend looking -> https://marketplace.visualstudio.com/items?itemName=sainoba.px-to-rem

  Marked as helpful

  1

  

  Flaviu Dragomir•150

  @FlaviuD94Posted about 2 years ago

  @AdrianoEscarabote I know a nice trick too. If you set at the beginning of css file body {font-size:62.5%} than 1rem will be 10px, and you don't need to convert it.

  1