Class based solution for product preview card component challenge
Design comparison
Solution retrospective
The most difficult part was inserting svg icon as a pseudo-element. I didn't achieve that so i used standard img
element.
If any kind soul knows how to insert svg with pseudo-element as a more elegant solution, or even some better solution, it will be kindly appreciated.
Community feedback
- @danielmrz-devPosted 5 months ago
Hello there!
Congrats on completing the challenge! ā
Your project looks great!
I have a suggestion about your code that might interest you:
š You can use the
<picture>
tag when you have different versions of the same image.Using the
<picture>
tag will help load the correct image to the user's device, saving bandwidth and improving performance.Example:
<picture> <source media="(min-width: 768px)" srcset="{desktop image path here}"> <img src="{mobile image path here}" alt="{alternative text here}"> </picture>
I hope this helps!
Other than that, excellent work!
1@appleseed9Posted 5 months ago@danielmrz-dev
Thank you for the comment.
picture
tag looks like a very elegant solution, will study it.IE doesn't support the
srcset img
attribute nor thepicture
element, which is interesting.0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord