cillianbc-qr-code-component-main

Community feedback

• Account deleted

  Hey there! Congratulations on successfully completing the coding challenge! I have some recommendations for your code that I think will be very helpful.

  When it comes to HTML, I noticed that the solution generates accessibility error reports due to non-semantic markup. This means that the page lacks landmarks, which are used to define major sections of the page instead of generic elements like <div> or <span>. To improve the accessibility and organization of your page, I suggest replacing the non-semantic <div> element with the semantic <main> element in your index.html file. Remember, each page should only have one <main> element that includes all content directly related to the page's main idea.

  As for images, since the component involves scanning the QR code, the image is not just a decoration and should have an alt attribute. This attribute should explain the purpose of the image, such as "QR code to frontendmentor.io". This will make the page more accessible and provide a better user experience for those using assistive technologies.

  I hope you find these suggestions helpful! Overall, the solution you submitted is great and I look forward to seeing your continued progress in coding. Keep up the good work!

  Marked as helpful

  1
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which lack landmark for a webpage

  ---

  • So fix it by replacing the wrapper <div> element with the semantic element <main> in your index.html file to improve accessibility and organization of your page.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>

  ---

  • They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

  ---

  iMAGES 📸:

  • Since this component involves scanning the QR code, the image is not a decoration, so it must have an alt attribute.

  ---

  • The alt attribute should explain the purpose of the image.

  ---

  • E.g. alt="QR code to frontendmentor.io"

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1