Christmas countdown timer using HTML, CSS and JavaScript

Community feedback

• 

  

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted about 4 years ago

  Hey, good work on this challenge, FesoQue! 👍

  It's cool that you made your solution Christmas-themed! 🎅

  I suggest,

  • Turning the social media links at the bottom of the page into actual links using the anchor tag.
  • The lights at the top of the page look great, but they are very stretched in the desktop layout of the page. You might want to consider adding multiple rows of lights in the desktop layout to prevent that from happening.
  • You can clear up some of the errors on your solution report by adding a <title> tag to the inline SVGs on your page. 😉

  Keep coding (and happy coding, too)! 😁

  And happy holidays! 🎄

  0

  ---

  

  FesoQue•380

  @FesoQuePosted about 4 years ago

  @ApplePieGiraffe thanks for your input, but I don't know understand the adding a <title> to the SVGs part? Can you elaborate??

  0

  

  

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted about 4 years ago

  @FesoQue

  It looks like you wrapped some inline SVGs in anchor tags (which is totally fine) but the solution report is complaining that there is no link content for those anchor tags (probably because there is nothing to indicate what those links are for to screen readers or something, IDK). If believe if you add a <title> tag to each of the inline SVGs, like

  <svg>... <title>Visit our Facebook page</title>... </svg>
  

  ...you should be able to clear up those errors and identify those links for accessibility purposes.

  Hope that helps! 😃

  0