Skip to content
Submitted 8 months ago

chllenge was to understand github and github pages .

farwaayunis•20
@farwaayunis
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

i would like to use js qr library instead of static image to implement it.

What challenges did you encounter, and how did you overcome them?

github pages was a new thing and it took me sometime to upload my project as instructed.

What specific areas of your project would you like help with?

i woud like to learn react and angular js and implement same chunck of code in it.

Community feedback

  • HelloTechTinu•670
    @tinuolaPosted 8 months ago

    Hi Farwaayunis. Good effort with your project. Although this project doesn't call for a lot of CSS, it is good to get into the practice of separating CSS code out of HTML/markup into a separate stylesheet (style.css file, for example).

    As for the code: since you've already applied flexbox centering to the 'body', there is no need to apply 'position:absolute' to the component. Any child inside the body will be centered vertically and horizontally. You'll just need to apply 'flex-direction: column' to the body so that the heading and the component are stacked.

    You also want to adjust the color contrast of the component text; it's very pale and hard to read against the white background. This is not ideal for accessibility.

    Now that you've submitted the solution, you should be able to see how others have coded this challenge. I recommend reviewing other people's solutions. It's a good way to learn and pick up tips.

    Good luck!

    Marked as helpful
    0
  • farwaayunis•20
    @farwaayunisPosted 8 months ago

    Thanks a alot .Really helpful . I am looking forward and practiing my skills more to achieve better results.

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord