Chat-app-css-ilustration

Community feedback

• 

  T

  Grace•31,230

  @grace-snowPosted almost 4 years ago

  Hi,

  This looks great. The phone image and text could be a little closer together, heading size and paragraph line height increased slightly, but those are pretty minor points.

  Well done 👍

  0

  ---

  

  T

  Grace•31,230

  @grace-snowPosted almost 4 years ago

  Some of the markup seems really strange to me, but to be honest I'm not sure how html should be treated in this kind of challenge. I would be tempted to aria-hide all of the phone markup and add an element with role of image and really descriptive alt text so it is still described to assistive tech. I expect that even having semantic markup in that phone screen would cause problems for SEO too... 🤯

  If it is being included, at the very least I would reverse the flex order of the two halves, so the h1 would come at the top of the html markup

  0