Design comparison
SolutionDesign
Solution retrospective
Please do give feedback. I wanted to know more about other ways to complete the task.
Community feedback
- @tesla-ambassadorPosted over 2 years ago
Hey Dhande! This is a really great challenge to flex some CSS muscle 💪 It's really neat! Here's a few pointers:
- The responsiveness is a little off between screen widths of 378px - 1150px you might want to add a few more media queries between those points so that you can resize some of your elements and this will prevent your display from breaking apart. You can also change the flex-direction to
flex-direction: column
at a screen width of 950px (it varies depending on how you resized the other elements) - On the mobile view, I couldn't scroll to see the text below because you had left the over-flow property on your <main> to
over-flow: hidde
You might want to change that to visible when you change the flex direction to column. - In order to fix some of your HTML validations and accessiblity issues, you might want to add an "alt" attribute to your <img> tags. Happy coding!
Marked as helpful0 - The responsiveness is a little off between screen widths of 378px - 1150px you might want to add a few more media queries between those points so that you can resize some of your elements and this will prevent your display from breaking apart. You can also change the flex-direction to
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord