Design comparison
Solution retrospective
I use body:before and body:after for the background images, not sure this method is normal practice among developer. Any feedback is very much welcomed. Thanks.
Community feedback
- @RayaneBengaouiPosted over 3 years ago
Hello mathew12tan,
Congrats for completing the challenge ! π
I think using pseudo classes to place images is fine. There are many ways to achieve this and they all have pros and cons !
However, I'm not sure with for the left image you are using
right: 71%
and for the right oneleft: 76.5%;
. Here you don't have to mess with percentages as usingleft: 0
for the left image andright : 0
for the right one would insure that they stick to the edges.Because on a bigger screen, your background images start to move away from the border. Also, by using 0 as a value you don't have to reformulate the property inside media queries as it's generic and will work on any screen size.
Overall, well done for the challenge and happy coding ! π
0@mathew12tanPosted over 3 years agoHi Enayar,
πThank you very much for your comment, will look into the background images again.
Happy coding! Mathew
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord