CSS and Flexbox solution

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted about 2 years ago

  Hi Cheg, congratulations on completing the challenge, great job! 😁

  Some little tips for optimizing your code:

  • add main tag and wrap the card for improve the Accessibility
  • also you can use article tag instead of a simple div to the container card for improve the Accessibility
  • remove all margin from .container class
  • use flexbox to the body to center the card. Read here -> best flex guide
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container
  • instead of using px use relative units of measurement like rem -> read here

  Hope this help! Happy coding 😉

  Marked as helpful

  1

  ---

  

  cheg•380

  @chegxPosted about 2 years ago

  @denielden thanks! I'll use your tips to solve the next challenge Product preview card component

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted about 2 years ago

  @chegx you are welcome! keep it up :)

  0