Chanel-card-component

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hi again Mileenka, congrats on completing this challenge!

  You’ve done really good work here putting everything together, I’ve some suggestions you can consider applying to your code to improve the html markup/semantic:

  THE PICTURE TAG is a shortcut to deal with the multiple images in this challenge. So you can use the <picture> tag instead of importing this as an <img> or using a div with background-image. Use it to place the images and make the change between mobile and desktop, instead of using a div or img and set the change in the css with display: none with the tag picture is more practical and easy. Note that for SEO / search engine reasons isn’t a better practice import this product image with CSS since this will make it harder to the image. Manage both images inside the <picture> tag and use the html to code to set when the images should change setting the device max-width depending of the device desktop + mobile.

  Check the link for the official documentation for <picture> in W3 SCHOOLS: https://www.w3schools.com/tags/tag_picture.asp

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  1
• 

  Mileenka•80

  @MileenkaPosted about 2 years ago

  @correlucas Thank you so much Lucas for taking a look at my code and for taking your time. :) I made a correction following your tips. If you could find a moment and see if that's what you meant, I'd be very grateful. :)

  1

  ---

  

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  @Mileenka I've checked and you've applied really well the picture tag! Everything seems fine now. I hope to see soon more of your projects. Have a good night.

  1