Chanel Project

Community feedback

• 

  Quelleris•190

  @QuellerisPosted almost 2 years ago

  Hello @clarisacosma! Congrats on your first project and welcome to Frontendmentor. If you don't mind, I have a few suggestions for you:

  • As it is said in your accessibility report, you should wrap your main content in <main> landmark. HTML landmarks are used to improve navigation experience on your site.
  • It's not recommended to set fixed height to components. That way the element is not responsive and can cause some issues like content being cut off. Instead let the content of the component define height. If you must, use min-height or max-height.
  • The same goes for width. Instead of setting fixed width with px like width: 700px, use min-width or max-width. It will set a width for a component and let it grow or shrink if necessary.
  • To make the component closer to the design, you can add width: 50% to #desc-containeron desktop, and width: 100% on mobile.
  • consider using class selectors instead of id selectors. The id can be used only on one, unique element and class selectors can apply to multiple elements.

  I hope this helps. Happy coding.

  Marked as helpful

  1