P
Steven Stroud• 4,140
@Stroudy
Posted
Great solution, Should be proud of this, few things i noticed,
align-items: stretch;
is making your card do some weird stuff, you should instead use something likeobject-fit: cover; width: 100%; height: 100%;
,- Should always use
max-width: 100%
ormin-width: 100%
overwidth:100%
this will make your site more responsive check out responsive-meaning by a frontend mentor dev. - Your media queries should use
rem
orem
notpx
. <img>
tag doesn't half aalt=""
for accessibility and SEO,- Missing a
<meta>
description tag - No
<main>
tag - You have used a lot of
<div>
tags which is semantically incorrect for example<img>
for images,<p>
for paragraphs,<h1> <h2>
for header tags
Keep coding, i look forward to seeing more from you.
0