Skip to content
Submitted about 1 year ago

challenge_preview

RehobothYimer•30
@RehobothYimer
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

first html and css challenge, any feedback would be good. thanks.

Community feedback

  • Øystein Håberg•10,710
    @Islandstone89Posted about 1 year ago

    Hi, congratulations on your first challenge. Here are some tips.

    HTML:

    • All pages needs a <main> that wraps the content (except header and footer). Apply it to the .card.

    • Alt text also needs to say where the QR code leads.

    CSS:

    • It's good practice to include a CSS Reset at the top. Andy Bell has a good one you can use.

    • min-height on <body> should be 100vh.

    • Remove fixed width on the card. Setting fixed dimensions is the quickest way into responsive issues.

    • You don't need a margin of 40px. 1 rem should be enough to prevent the card from reaching the viewport edge on smaller screens.

    • You only need to put text-align: center once, on the .card. This will give you the same result, but with one less line of code.

    0
    RehobothYimer•30
    @RehobothYimerPosted about 1 year ago

    @Islandstone89 thank you for the feedback, will do so.

    1
  • ferrychris•100
    @ferrychrisPosted about 1 year ago

    nice startup. proceed to next Project Dev.

    0
    RehobothYimer•30
    @RehobothYimerPosted about 1 year ago

    @ferrychris thanks will proceed

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord