Challenge-8

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted about 2 years ago

  Hi Fher, congratulations on completing the challenge, great job! 😁

  Some little tips for optimizing your code:

  • use main tag to wrap the card for improve the Accessibility and not as container of element
  • use article or div tag instead of a simple div to the container card for improve the Accessibility
  • use img element for the top image of card istead of a style div
  • remove all margin from main tag
  • use flexbox to the body to center the card. Read here -> best flex guide
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container
  • instead of using px use relative units of measurement like rem -> read here

  Hope this help! Happy coding 😉

  0