Challenge#5-Columns3

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  CSS 🎨:

  • Looks like the <footer"> element has been placed bottom using margin. So let me explain, How you can place the component at bottom with using fixed positioning for footer

  ---

  ---

  • Luckily you already used Flex layout of css to center the component, So you just want to add fixed position for <footer> element to place it in bottom of the page

  footer {
     position: fixed;
     bottom: 1em;
  }
  

  ---

  • Now remove these styles, after removing you can able to see the changes

  ---

  .contenedor {
    margin-bottom: 5rem;
  }
  

  ---

  • Now your component has been properly at bottom

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  0
• 

  P

  Piwko Marcin•180

  @PiwkoOPosted over 1 year ago

  Hi your solution looks great, but I have a few suggestions:

  • For devices between 375px to 660px it would look better if you add an additional breakpoint
  • Your class naming would be better in English so when you join an international team you don't have to suddenly switch and you would be more used to the naming convention
  • Class names like [name]1, [name]2, etc are not very readable for other developers. It should be more descriptive so that when someone else is looking at your code it doesn't require to dive into html file
  • Your repeat the same code in different places. In that case, is better to create joined rules for a few classes and separate rules for the particular class.

  0