Submitted almost 2 years ago
Challenge Social Proof Section solution using HTML and CSS properties.
@Ghazanfar429
Design comparison
SolutionDesign
Solution retrospective
Feedbacks are welcome:
- Any alternate way to add circular image in buyer section.
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- The “star icons” serve no purpose other than to** be decorative ⚠️;** They add no value. Their
alt tag
should left blank to hide them from assistive technology.
More Info:📚
https://www.w3.org/WAI/tutorials/images/
- The profile images
alt tags
description needs to be improved ⚠️. It should state the person’s full name.
More Info:📚
- For the testimonials, it is best ✅ to to wrap each individual testimonial component in a
figure
element, the individuals information should be wrapped in afigcaption
element and lastly, the testimonial itself should be wrapped in ablockquote
element.
Code:
<figure> <blockquote></blockquote> <figcaption></figcaption> </figure>
More Info:📚
- There is no need to have separate stylesheets ❌, as it can affect site performance. Instead have one single stylesheet ✅.
- NEVER ❌ do this as it creates accessibility issues for users and it is outdated, instead download a
px
torem
/em
converter in your code editor.
html { font-size: 62.5%; }
More Info:📚
Should I change the default HTML font-size to 62.5%?
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🎆🎊🪅
Marked as helpful0 - The “star icons” serve no purpose other than to** be decorative ⚠️;** They add no value. Their
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord