Challenge QR code using mobile-first solution, SASS, BEM and Flexbox.

Community feedback

• 

  Boris•2,850

  @mkborisPosted 3 months ago

  Hi @LesSyl great job completing your first challenge, here are a few things to review

  • Your BEM naming convention looks mostly correct, but there are a couple of points you could consider to improve, ensure the block name is descriptive (e.g., qr-code-box instead of box), use more specific element names (qr-code-box__heading instead of box__text-h2 and qr-code-box__description instead of box__text-p).
  • All content should be wrapped within landmarks. Wrap a main tag around the .box and a footer for the attribution.
  • Change the height of the body to min-height, using min-height ensures the content can grow beyond the viewport height if necessary, while height would restrict it to exactly the viewport height, potentially causing overflow issues with content that exceeds this height.
  • Your image needs a more descriptive alt attribute like so alt="Qr Code to Frontendmentor.io"
  • You really need any media query for this challenge
  • I would advise against using the "62.5% font size technique." See why here

  Hope this helps, Good luck.

  Marked as helpful

  0