challenge QR code

Community feedback

• 

  Rafif Adli Mulya•70

  @rafifadlimulyaPosted over 2 years ago

  to put your card on the middle of the screen = body{ display: flex; align-items: center; justify-content: center; min-height: 100vh; }

  to set distance you can use gap and margin :D

  Marked as helpful

  0
• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  Hello, Baptiste! 👋

  Congratulations on completing your first Frontend Mentor challenge! 🎉 Good effort on this challenge! 👍

  Some suggestions from me.

  • I would recommend keeping the .gitignore file in the remote repository. Right now, there's a .DS_Store file in the repo.
  • There's no need to use role attribute in this case. Instead of making the body element as the main element. I would suggest putting a main tag as the direct child element of the body element. Also, a role attribute can't be filled with a random value.
  • QR code image is the main content of the page so it should not be hidden from the assistive technology like screen reader. It should contain an alternative text like "QR code for Frontend Mentor".
  • Remove the commented code. If another developer (it can be you in the future) wants to improve this solution, he/she might get confused about whether or not the commented code should be used or deleted.

  That's it! I hope this information is useful! 😁

  0