Design comparison
Community feedback
- @VCaramesPosted about 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
-
The Alt Tag description in the logo needs to be improved upon. The logo is arguably the most important image in you page. So the description should state the company name.
-
Your "buttons" were created with the incorrect element. When the user clicks on the button they should directed to a different part of you site. The Anchor Tag will achieve this.
-
The Illustrations serve no other purpose than to be decorative; They add no value. Their Alt Tag should left blank and have an aria-hidden=“true” to hides it from assistive technology.
-
The
article
element is not needed for this challenge. -
the
footer
links need to wrapped inside anav
element.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🍂🦃
Marked as helpful0@fruizoteroPosted about 2 years ago@vcarames Thank you very much, since this project I'm trying to improve my html semantics because I thought it didn't matter much, but after reading my old code full of divs, I realised how important it is. Thank you very much for the tips. And what do you mean the article is not necessary?
0@VCaramesPosted about 2 years ago@fruizotero
I am glad that I was able to help you out! Keep it up!
You are currently using the
article
element to wrap your sections, for example ".article article--gap-3".The are no articles in this challenge, so there is not need to use an
article
element. In order to be able to use anarticle
, they need to be able to stand on their own and be independently reusable (think Yahoo, Medium, etc...).0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord