@Fable54321
Posted
ok, so looking at your code;
1st- I think one thing you could add to your reset.css file for every project is a min-height: 100vh to the body tag.
The reason why I'm starting with this is that it would have given you the possibility to center your content vertically, wich is the obvious visual issue with your page.
2nd- wihtout going one by one I can see there is a few things that are not respecting the style guide.
Since you are using SASS, what I like to do is to have a _variables.scss file, where I start by creating a variable for each information given by the style guide. You would then need to import your variables using @use "variables"; in your style.scss.
If it's in the style guide it means it is used somewhere so you can see it almost as a checklist, alhtough having used all of them doesn't guarantee perfection, having not used all of them guarantee something is wrong.
3- I recommend the use of em for media queries. They are the most consistent across all browsers. (50em is a good spot to begin with).
There is probably a few other things I could find, I can see your container size is weird when I inspect your page, but overall you did a good job, we recognize the design really well.
I would recommend that maybe you just take a bit more time in the future and I am sure you can make everything perfect. Keep up !
Marked as helpful