Challenge

Community feedback

• 

  P

  Steven Stroud•11,910

  @StroudyPosted 3 months ago

  Hey, Great job with this solution you should be proud, A few things I noticed,

  • These two meta tags are important for ensuring that a webpage displays correctly across different devices and browsers, Together, these tags ensure proper text display and responsive design, enhancing usability and accessibility across various devices.

  <meta charset="UTF-8" />
  <meta name="viewport" content="width=device-width, initial-scale=1.0" />
  

  • Background and foreground colours do not have a sufficient contrast ratio, Low-contrast text is difficult or impossible for many users to read. Check out this Discover and fix low-contrast text with Chrome DevTools,
  • You don't have legible font sizes, Font sizes less than 12px are too small to be legible and require mobile visitors to 'pinch to zoom' in order to read,
  • Missing a <meta> description tag for SEO purposes,
  • Inaccessible buttons/links because they are wrapped in a <p> element which is incorrect syntax.
  • It is best practice to have a <main> tag inside your body highlighting the main section.
  • ‍Using max-width: 100% or min-width: 100% is way more responsive then just width:100%, check out this article also from the same Frontend mentor dev responsive-meaning, she goes into more detail.
  • You should avoid using px as it is an absolute unit and not a responsive unit like rem or em, You should look at this article from a Frontend mentor dev, Why font-size must NEVER be in pixels.
  • Another great resource for px to rem converter.
  • You should apply a full modern reset to make things easier as you build, check out this site for a Full modern reset
  • Using a naming convention like BEM, Using proper naming will prepare you for the changes in design of the website.
  • It is best practice to use margin-inline: auto; to center left and right then than just margin: auto;, You can center the height by using this code snippet

    min-height: 100svh;
    display: flex;
    justify-content: center;
    flex-direction: column;
  

  I know this is a lot to take in but just take it slow, I hope you found some of this information helpful, You should give the articles a good read and I look forward to seeing some more from you, Happy coding! 💻

  Marked as helpful

  0

  ---

  

  Malkah04•180

  @Malkah04Posted 2 months ago

  I appreciate your comment and it help me ,thank you @Stroudy

  1