Challenge 4: 3-Column Card Component

Community feedback

• 

  P

  Adriano•42,680

  @AdrianoEscarabotePosted about 2 years ago

  Hi Nicholas Nall, how are you?

  I really liked the result of your project, but I have some tips that I think you will enjoy:

  To improve the code structure, wrap this div:

  <div class="attribution">
      Challenge by <a href="https://www.frontendmentor.io?ref=challenge" target="_blank">Frontend Mentor</a>.
      Coded by <a href="#">Nick</a>.
  </div>
  

  with the semantic tag footer.

  change the button tag to an a tag, taking into account that the button is Learn more, I imagine this is not a form, or something like that, this button would probably take us to another page, read more about! so I think the a tag is the best choice in this case!

  The rest is great!

  I hope it helps... 👍

  Marked as helpful

  1
• 

  Jeck•1,080

  @j-tomajinPosted about 2 years ago

  Hello!

  tips for attribution,

  • you may wrapped it inside a footer element

  • for it to be stick at the bottom you can:

  body {
     position: relative;
     min-height: 100vh;
  }
  
  footer {
     position: absolute;
     bottom: 0;
     left: 0;
     right: 0;
  }
  

  HAPPY CODING!

  Marked as helpful

  0

  ---

  

  Nicholas Nall•140

  @nnallPosted about 2 years ago

  @AsukalDePapa

  Thank you!

  1