Challenge #3 --> CSS and HTML

Community feedback

• 

  Raymart Pamplona•16,100

  @pikapikamartPosted over 3 years ago

  Hey, ughm okay. The reason for that. But first, could you change the url that you provided in your view code so that we could see your repository. Right now that url on that, is the url on the live site.

  Okay, so as I inspected, you declared a breakpoint at 92rem which is when converted 1472px. The original design is for 1440px, so logically, you initially gave the mobile state. Lower it down.

  Other suggestion would be that;

  • Height. On your even-columns selector, you made used of height:100vh which I always recommend not using on a main component, especially when it is container type. So by doing this, when you inspect at dev tools from the bottom, your layout is pushed on to the top, not scrollable and cut out. The layout is overlapping each other as well. It will be better if you used other units like rem so that it will not scale according to the viewport like it is doing right now.

  The mobile state is good, but please consider what I mentioned above. If you are creating sites, always inspect it in dev tools so that you could see any wrong with it. I also think you are using a large screen.

  But still, good work on this^

  0
• 

  Xhoni•70

  @Xhoni43Posted over 3 years ago

  idk , but if u do preview site is differente from the screenshot

  0