Challenge #2 - NFT preview card component

Community feedback

• 

  Rio Cantre•9,690

  @RioCantrePosted over 2 years ago

  Hello there! Awesome work with this challenge. Looking at your solution, I think you should know the following as well…

  • Add color: var(--pc-cyan) for the .text-title:hover and .user-name:hover rule sets
  • Instead of div, alternatively wrap the whole content with semantic tags, for HTML structures, refer it with this one Semantics. For instance, this line <div class="container"> can be wrap with main tag and this <div class="inner-container"> with section tag
  • Include alt with description in image tags. Like this line <img class="small-icon" src="images/icon-ethereum.svg"> but optional

  In the brighter side...

  • The CSS file is well organized with proper usage of properties, specially with the root variables
  • The HTML structure is clean and readable
  • The project is responsive and utilized the details accordingly based on the original design
  • Great job with the hover state of the hero image.
  • The alignments are properly done

  Above all, the project is well implemented. Keep up the good work!

  Marked as helpful

  1