Challenge 2 - NFT preview card

Community feedback

• 

  Naveen Gumaste•10,480

  @NaveenGumastePosted almost 3 years ago

  Hay ! Good Job you made it look nearly perfect to the preview

  These below mentioned tricks will help you remove any Accessibility Issues

  -> Add Main tag after body like it should be your container

  -> For 1st heading or h1 tag, use header tag and then inside the header put your h1 or h2 etc

  -> But use header tag only once in main heading element.

  Keep up the good work!

  Marked as helpful

  1

  ---

  

  Ankitha Pai•20

  @ankithapaiPosted almost 3 years ago

  @Crazimonk Thank you for taking time and responding :) appreciate it. I will take these points into consideration and also try to make the changes!

  1
• 

  Rio Cantre•9,690

  @RioCantrePosted almost 3 years ago

  Hello there! Good job with this challenge. Viewing your solution, I think you should considered the following as well...

  • To add the line, simple add a border in the .end rule set and other properties like this...

  .end {
    width: 100%;
    border-top: 1px solid white; (change the color value)
    margin-top: 1rem;
  }
  

  • Remove the height of the main image
  • Adjust the height of the container into 500px
  • Wrap the container with main tag and attribution with footer tag
  • Clean the whitespaces in your code

  Overall you did good and Keep it going!

  Marked as helpful

  1

  ---

  

  Ankitha Pai•20

  @ankithapaiPosted almost 3 years ago

  @RioCantre Thank you for taking time and responding :) appreciate it. I will take these points into consideration and also try to make the changes!

  This definitely helps

  1
• 

  Licht•50

  @DeadParadoxPosted almost 3 years ago

  Hey! I'll give you a hint for that line, there are many ways to do that, but try pseudoelements. Kevin Powell on youtube explains them well. :)

  And for the shadow on the box which you also skipped, there is a CSS property which can do that for you. Search the documentation (like devdocs.io/css/)

  Marked as helpful

  1

  ---

  

  Ankitha Pai•20

  @ankithapaiPosted almost 3 years ago

  @DeadParadox Thank you for taking time and responding :) appreciate it. I will review the topic and will try to change

  0
• 

  Martin Michael•20

  @MartinMngodoPosted almost 3 years ago

  Try using <hr> and then give it a lower opacity.

  1