Challenge #1

Community feedback

• 

  Samuel Palacios•615

  @samuelpalaciosdevPosted over 3 years ago

  Hi, Xhoni👋

  Great job on this challenge. Your solution looks good and it scales pretty well. 👍

  I only suggest some things 😉:

  • On mobile viewport the menu isn't centered. As I'm seeing on your project that's because you set a margin-left to the anchor links (.hero > .navbar > .nav-links > li a) , I'd delete the margin-left and add align-items: center; on the ul which in this case you selected as: .hero > .navbar > .nav-links.

  • Be careful with specificity. I mean, you have extra large selectors like the one I mentioned above, you could simplify that setting a class to those elements and just selecting the class. As an example, adding this class to the anchor link <a class= nav__link>, you could select it on CSS as .nav__link, and it is easier to read than the other selector

  I hope this would help you, have a nice day, keep coding!💙

  1

  ---

  

  Xhoni•70

  @Xhoni43Posted over 3 years ago

  @samuelpalaciosdev Thx mate i will do the best in my next project

  0

  

  Samuel Palacios•615

  @samuelpalaciosdevPosted over 3 years ago

  @Xhoni43 You're already doing your best! Remember, learning to code is a non-linear process and forcing a strictly linear structure on it will slow your learning process. It is analogous to learning a language.

  0
• 

  Vinci Taylaran•185

  @vincitaylaranPosted over 3 years ago

  Great looking solution, Xhoni! The only thing I would have to knit pick is that the hero isn't dimmed. Making it dim will make the white text on it pop out more and appear more readable.

  .hero {
      background: linear-gradient(rgba(0,0,0,0.5), rgba(0,0,0,0.5)), url(../assets/image-hero.jpg) no-repeat center center/cover
  }
  

  Otherwise, this looks really good! Looking forward to your progress :)

  1

  ---

  

  Xhoni•70

  @Xhoni43Posted over 3 years ago

  @vincitaylaran thanks i done this but for some reason i delete it volontary ahah , so thanks i proceed to change it

  0
• Account deleted

  It's really good but some important détails missed out, like the heading who is bold (in solution not) or text-align ! But really nice !

  1

  ---

  

  Xhoni•70

  @Xhoni43Posted over 3 years ago

  @thibault-deverge thanks I noticed it now I proceed to change it

  0