Challenge 002: QR Code Component

Community feedback

• 

  Rob Vermeer•170

  @RobVermeerPosted over 2 years ago

  Nice solution!

  I only have one small but in my opinion important point of feedback. Images should always have a width and height defined on the element. This way the intrinsic size of the image is known to the browser and the browser already knows how much space it needs to reserve for it. Without this you would see a layout shift whenever the image is loaded in (this is especially visible when user has slow internet). Nowadays Google thinks this is really important =)

  You can read more about this here https://web.dev/cls/ and https://developer.mozilla.org/en-US/docs/Web/HTML/Element/img

  Marked as helpful

  0