Chall using Flex, SCSS, JS

Community feedback

• 

  Boots 😺•1,590

  @adityaphasuPosted over 1 year ago

  Hello, @AlexDDevv~

  • The reason why the favicon doesn't work is because you forgot to put a / before the assets in the href xD
  • To fix it just add the / before the assets like this:

  href="./assets/images/favicon-32x32.png"
  

  Just a quick fix for the images stretching out in mobile view, remove the explicit height from the .section-img div:

  main .section-img {
      height: 300px;         //remove this we don't need it
  }
  

  • Instead you can just add a global style for all the images like this:

  img {
      max-width: 100%;
      height: auto;
      display: block;
  }
  

  This way the image won't stretch and you won't need to explicitly set heights on the divs because while setting heights is okay in this case the images start to stretch to fit the height specified.

  Apart from this small fix, everything looks good! I don't think the navlist would be an issue since there's a transition on it we get that glitched-out thingy when we stimulate the screen sizes in devtools. It should look fine for mobile devices.

  Keep up the hard work and happy coding!🙌🏻

  0