@denielden
Posted
Hi Max, congratulations on completing the challenge, great job! π
Some little tips for optimizing your code:
- add
main
tag and wrap the card for improve the Accessibility - use
class
to style the element and not aid
because it must be unique into all the page - use
p
for the text of card instead ofh2
- add descriptive text in the
alt
attribute of the images - centering a
div
withabsolute
positioning is now deprecated, it uses modern css likeflexbox or grid
- use flexbox to the body to center the card. Read here -> best flex guide
Hope this help! Happy coding π
Marked as helpful
@K4zuki-dev
Posted
@denielden Thank's for the tips, I updated the code now and I fixed the things you told me to, the ID's are gone and replaced with classes, h2 is now a p, and especially the way I aligned it to the center of the site, Flex is waaay easier and it'll be helpful for sure in the future, thanks for your feedback!
@denielden
Posted
@K4zuki-dev You are welcome and keep it up :)