Centering a div and image

Community feedback

• 

  Bence Zámbó•510

  @zambobencePosted over 2 years ago

  Great job, I really like the box-shadow. :)

  I would declare a fixed width to the card. Declaring the card width in percent is using the width of its parent. In this case, the parent of the div class ="card" is the body the width of the body which is the viewport. It causes in this case distortion in different screen sizes.

  .card {
  width: 300px
  }
  

  I hope I could help you with this.

  Marked as helpful

  0

  ---

  

  Silent_Anu•10

  @Silent-AnuPosted over 2 years ago

  @benceturbulence I was aware of the issue and believe me, I was so very tempted to just use fixed-width, but it goes against everything that I am taught. Both udemy and youtube advise to limit the use of fixed-width as much as possible and to use max-width instead.

  Now I am thinking I'll just use fixed width for the next challenge.

  Thanks!

  1

  

  Abdul•8,540

  @SamadeenPosted over 2 years ago

  @Silent-Anu The use of fixed width is not advisable though. max-width is preferable. and the aim is for the width to change per screen size.

  0
• 

  Abdul•8,540

  @SamadeenPosted over 2 years ago

  Hey!! Cheers 🥂 on completing this challenge.. .

  Here is my suggestions..

  • You should use <main class="card"> instead of <div class="card">. This should fix most of your accessibility issues

  . Regardless you did amazing... hope you find this useful... Happy coding!!!

  0