Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Center Responsive QR Code Component - #challenge_01

rishi 60

@rishi-jsdev

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I used a lot of percentages, is it best practices?

Can you please provide some tips on responsive design?

Do you guys know how to better center a flexbox element?

Community feedback

@0xabdulkhaliq

Posted

Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

HEADINGS ⚠️:

  • This solution consists incorrect usage of <h4> so it can cause severe accessibility errors due to incorrect usage of level-four headings <h4>
  • Every site must want only one h1 element identifying and describing the main content of the page.
  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.
  • In this solution there's <h4> element which is this <h4>Improve your...</h4>, you can preferably use <h1> instead of <h4>. Remember <h1> provides an important navigation point for users of assistive technologies so we want to use it wisely
  • So we want to add a level-one heading to improve accessibility
  • Example: <h1>Improve your front-end skills by building projects</h1>
  • If you have any questions or need further clarification, and feel free to reach out to me.
  • If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.

QR iMAGE ALT TEXT 📸:

  • Since this component involves scanning the QR code, the image is not a decoration, so it must have an alt attribute.
  • The alt attribute should explain the purpose of the image.
  • E.g. alt="QR code to frontendmentor.io"
<img src="/images/image-qr-code.png" alt="QR code to frontendmentor.io">

.

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!

Marked as helpful

1

rishi 60

@rishi-jsdev

Posted

@0xAbdulKhalid

Thanks a lot for the feedback, Abdul! I will keep your accesibility points in mind. 🙏

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord