Cartão de Produto

Community feedback

• 

  Daniel 🛸•44,250

  @danielmrz-devPosted 9 months ago

  Olá @tatyanepgoncalves!

  Seu projeto ficou ótimo!

  Notei que você utilizou margin pra centralizar o card. Usar margens não é a melhor opção pra centralizar elementos.

  📌 Existe uma forma melhor e mais eficiente de posicionar elementos no meio da página (tanto na horizontal quanto na vertical):

  • Aplique isso ao body (Pra funcionar corretamente, não use position ou margins):

  body {
      min-height: 100vh;
      display: flex; /*  também funciona com grid  */
      justify-content: center;
      align-items: center;
  }
  

  Espero que ajude!

  Fora isso, você fez um excelente trabalho!

  Marked as helpful

  0
• 

  Alok Suman•2,380

  @Alokray007Posted 9 months ago

  Hello there 👋

  Good job on completing the challenge !

  Your project looks really good!

  I have a suggestion about your code that might interest you.

  There is an very useful browser extension called Perfect Pixel that allow you compare with the design image and thus see the exact dimensions. I recommend it to you.

  📌 Tags like <div> and <span> are typical examples of non-semantic HTML elements. They serve only as content holders but give no indication as to what type of content they contain or what role that content plays on the page. This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.

  I hope this suggestion is useful for future projects.

  Other than that, great job!

  Happy coding.

  Marked as helpful

  0