Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Cards about cars

Pedro Lucasβ€’ 20

@pedroldlima

Desktop design screenshot for the 3-column preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Cards HTML and CSS

It's not very original to the base project, but I hope the community likes it, I accept criticism

Community feedback

Colten Siemerβ€’ 200

@Coltensiemer

Posted

Hey Pedro,

Great job with this solutions! Your code looks well done and the result is great. I like how you mark comments on your CSS to help keep it more easy for others to read and understand.

I would recommend to always include an alt"" with text inside. This is for accessbility. It is a good habit to get!

Check out this resource to learn some more! https://developer.mozilla.org/en-US/docs/Web/HTML/Element/img

Marked as helpful

1

Colten Siemerβ€’ 200

@Coltensiemer

Posted

@MelvinAguilar

Ah! This is great for myself to learn and practice myself! Thank you Melvin.

0

@MelvinAguilar

Posted

Hello there πŸ‘‹. Good job on completing the challenge !

I have some suggestions about your code that might interest you.

  • You should use only one <h1> tag per page. The <h1> tag is the most important heading tag, This can confuse screen reader users and search engines. This challenge requires that Sedans, SUVs and Luxury are headings, but you can use the <h2> tag instead of the <h1> tag. You can read more about this here πŸ“˜.
  • You should not use inline-CSS because it is not a good practice. Instead, you should use an external stylesheet to style your page. By doing this, you will be able to have a better organization of your code and will be able to understand it better.

I hope you find it useful! πŸ˜„

Happy coding!

Marked as helpful

0
Abdul Khaliq πŸš€β€’ 72,660

@0xabdulkhaliq

Posted

Hello there πŸ‘‹. Congratulations on successfully completing the challenge! πŸŽ‰

  • I have other recommendations regarding your code that I believe will be of great interest to you.

HTML 🏷️:

  • Your solution generates accessibility error reports due to wrong usage semantic markup
  • So fix it by replacing the <section> with semantic element <main> and convert those three <main> into <section> to improve accessibility and organization of your page.

I hope you find it useful! πŸ˜„ Above all, the solution you submitted is great!

Happy coding!

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord