Card-Component

Community feedback

• 

  Lucas 👾•104,400

  @correlucasPosted about 2 years ago

  👾Hello HMADAMK, congratulations for your new solution!

  I saw your solution and seems already great, two things you can do to improve, one is to make the container card responsive by replacing its width with max-widthto allow the card contract while scaling, note that is currently fixed the width size. Other thing is to wrap the whole card contents with main instead of div.

  👋 I hope this helps you and happy coding!

  Marked as helpful

  0
• 

  David•8,000

  @DavidMorgadePosted about 2 years ago

  Hello Hmadamk, congrats on finishing the challenge! great work!

  It seems that you had a bit of trouble getting the profile card centered, try using flex-box directly on your container after removing the margin on your card class like this :

  .container {
    display: flex;
    justify-content: center;
    align-items: center;
    min-height: 100vh;
  }
  

  Great work with the images, maybe setting them as a CSS background-image could have landed a better result, but you still got it!

  Hope my feedback helps you!

  Marked as helpful

  0