Design comparison
Solution retrospective
The most difficult was the hover effects but I think the challenge was taken up. I'm waiting for your FeedBack, thanks :)
Community feedback
- @correlucasPosted about 2 years ago
πΎHello @Hatchino, Congratulations on completing this challenge!
π¨βπ» Here are some tips to improve your solution code:
1.Fix the component responsiveness, its not working yet and this is due the
fixed width
you've applied to the container. The difference betweenwidth
andmax-width
is that the first(width) is fixed and the second(max-width) isflexible
and make the element shrink when the screen starts to scale down. So if you want a responsive block element, never usewidth
choose ormin-width
ormax-width
.2.The image is not responsive yet, a quick way to make any image responsive and respecting the container size is to add
display: block
andmax-width: 100%
to the<img>
selector. To improve the responsiveness even more adding the auto-crop property you can addobject-fit: cover
to make the image crop inside the container its inside.img { display: block; object-fit: cover; max-width: 100%; }
βοΈ I hope this helps you and happy coding!
0@HatchinoPosted about 2 years agoThank you @correlucas, I fixed the responsive component, it is true that I have the annoying habit of putting fixed widths.
Happy coding too !
1@correlucasPosted about 2 years ago@Hatchino You're welcome Lea, than say me if works and If was useful for you! Have a good night.
0@HatchinoPosted about 2 years agoHello @correlucas, I noticed a mistake at the top right and bottom left border. I have no idea how to fix it.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord