Design comparison
Solution retrospective
Hello! It is my first project, I know that I have to improve many things so I will be happy if you advise me so I can learn more and progress :)
Community feedback
- @ccreusatPosted almost 3 years ago
Hello ! Welcome to Frontend Mentor :)
As Ryan said, you should check the design again but here come some ideas:
-
you don't have to add a fix height to your .container
-
your .img seems useless, I would recommend only add these declarations on your <img/> :
display:block; max-width: 100%; height: auto; border-radius:10px;
This part should have a link (<a/>) with the eye icon (excepting to go somewhere with this link of course) -
Card max width should be 350px
-
Check your font sizes :)
Marked as helpful1 -
- @namlh023Posted almost 3 years ago
I saw your live site does not quite like the design. You should check that again! (I had some problems when setting up my Github-Pages too).
You did a pretty job with the image hover. I didn't think about using pseudo-element :)). But I didn't understand why you used h2, h3, and h4. That would have been <p> for me.
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord