@VCarames
Posted
Hey there! 👋 Here are some suggestions to help improve your code:
- To properly center your content to your page, you will want to add the following to your <Body> Element (this method uses CSS Grid):
body {
min-height: 100vh;
display: grid;
place-content: center;
}
-
To not only improve your HTML code but to also identify the main content of you page, you will want to wrap your entire component inside the Main Element.
-
The image’s “Alt Tag” description needs to be improved upon to better describe what it is. You will want to assume that you are describing the image to a someone.
-
This component requires the use of two images 🎑 at different breakpoints. The Picture Element will facilitate this.
Here is an example of how it works: EXAMPLE
Syntax:
<picture>
<source media="(min-width: )" srcset="">
<img src="" alt="">
</picture>
More Info:
https://www.w3schools.com/html/html_images_picture.asp
https://web.dev/learn/design/picture-element/
- Currently, the old price (169.99) 🏷 is not being properly announced to screen readers. To fix this, you are going to wrap the the price in a Del Element and inside it you will add a Span Element with an sr-only class that will state something like “The previous price was…” and use CSS to make it only visible to screen readers.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🍂🦃