Card to rating using CSS Flex box and vue

Community feedback

• 

  Adriano•38,270

  @AdrianoEscarabotePosted almost 2 years ago

  Hi Rafael De Souza Santos, how are you? Welcome to the front-end mentor community! I really liked the result of your project, but I have some tips that I think you will enjoy:

  As you know this project is based only on one page component, so no h1 is needed! because we don't know if this page will have a more important component, but it's always good to prevent accessibility errors so I think it would be good for you to add an h1 in this component, besides being a good practice for when you are developing larger sites, don't worry forget about h1.

  To improve the structure of the html document, prefer to wrap all the content with the main tag, since this challenge is just a component, it needs a main tag to know what the main content of the page is!

  avoid using px, If your web content font sizes are set to absolute units, such as pixels, the user will not be able to re-size the text or control the font size based on their needs. if you want to keep using px for development and then format the whole code to rem, you can use this vscode extension: px to rem

  The rest is great!

  I hope it helps... 👍

  Marked as helpful

  1

  ---

  

  Rafael•40

  @RafaelDSSPosted almost 2 years ago

  @AdrianoEscarabote Thank you for the tips :)

  1
• 

  Travolgi 🍕•31,400

  @denieldenPosted almost 2 years ago

  Hello Rafael, You have done a good work! 😁

  Some little tips to improve your code:

  • add main tag and wrap the card for improve the Accessibility
  • add descriptive text in the alt attribute of the images
  • remove all unnecessary code, the less you write the better as well as being clearer: for example the div container of image
  • use min-height: 100vh to .container class instead of height, otherwise the content is cut off when the browser height is less than the content
  • add transition on the element with hover effect
  • instead of using px use relative units of measurement like rem -> read here

  Keep learning how to code with your amazing solutions to challenges.

  Hope this help 😉 and Happy coding!

  Marked as helpful

  1

  ---

  

  Rafael•40

  @RafaelDSSPosted almost 2 years ago

  @denielden Thank you for the feedback. These tips will help me a lot :)

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted almost 2 years ago

  @RafaelDSS You are welcome and keep it up :)

  0