T
Gwenaël Magnenat• 1,270
@gmagnenat
Posted
Hi,
Congrats on completing the challenge!
I had a check on your repo and I can give you a few comments.
On the markup : I think you don't need to use so many section and the markup could be much more readable. I don't think nesting the two inner sections inside a span is useful. You can go with simple markup for this.
for the button icon you could use a :before pseudo element as the icon is strictly decorative here.
on the design : the image is slightly modified, you can use a css filter to push the contrast and control brightness.
These are just small things I noticed while reviewing your code. Overall your solution looks great.
Happy coding !
0
