Design comparison
Solution retrospective
Hello community, I have finished this project and I really like the design and I added a small animation for the social links, if you have some improvements for my code, or about the accessibility, you can tell me in the comments, really help me to improve. Thanks and Happy coding. 🍕
Community feedback
- @Tryt4nPosted over 1 year ago
Between width of 480px to around 700px on your social link icons narrow because you use
width: 30%
on.footer__social
. Also for<form>
element you could add somepadding-inline
because below 580px elements inside touch the edges and personally I would addtext-wrap: nowrap;
on yourbutton
because between 480-570px text is wrapping. For image you could change it so that it is always the same width as theform
.For accessibility:
- text "soon" in your
h1
could not be visible for assestive technologies. Instead of that you could wrap it instrong
orb
or just leave it as it is and add<span class="visually-hiden>soon</span>
label
is empty. You could addspan
withvisually-hiden
class and some text like "email"- add
aria-errormessage="some_id"
to yourinput
- to you warning text add this
id
andaria-live="assertive"
- © symbol is the same as
© ;
but without space between letter "y" and sign ";" - you could add some description for your footer navigation like
aria-label="social links navigation"
because in real website it would be probably just a component and there would be anothernav
elements
Personally I would change
span
forp
with your text "Subscribe and get notified.p
is for paragraph andspan
is just likediv
but it hasdisplay: inline;
Marked as helpful1 - text "soon" in your
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord