Card feature section (CSS flexbox + grid)

Community feedback

• 

  Khrystyna Horbenko•230

  @KristinaHorbenkoPosted about 1 month ago

  This is a very interesting solution for card placement. The chosen grid and responsiveness add structure to the design and make it user-friendly across different devices. However, it's worth paying attention to the fixed margins for images. In the CSS, the fixed margins for images (margin: 25px 0 0 200px; and margin: 30px 0 0 232px;) can cause issues with responsiveness. It would be better to use flexible values like percentages or rem for smoother scaling across various devices. Unoptimized CSS: There are many repeated styles for the article element. For instance, width, height, border-radius, and padding-left could be placed in a common class for all articles, which would reduce the code volume and make it easier to maintain. Lack of color variables: Color values (hsl(...)) are repeated multiple times in the code. Using CSS variables for colors would make it easier to change the color scheme in the future.

  Marked as helpful

  0
• 

  collins-ai•230

  @collins-aiPosted about 1 month ago

  Congratulations on your solution, the solution is looking almost like the original design. Semantic html like header and footer are present in your code which is very nice. The accessibility of the solution is also very good. Concerning the layout it looks ok in different screen sizes but in smaller laptops it doesn't fit properly.

  0
• 

  manuel360•110

  @manuel360Posted about 1 month ago

  Great layout cheers 🥂 my only problem was the box shadow it was only at the bottom of the card but apart from that 👌

  0